From d3f7db3e5c68b555be059c8dc3125eef48d79577 Mon Sep 17 00:00:00 2001 From: xdavidwu Date: Sun, 24 Jul 2022 13:08:40 +0800 Subject: [PATCH] fix various lints --- build.gradle | 10 +++++----- src/main/AndroidManifest.xml | 4 ++-- .../java/org/safsftp/SFTPDocumentsProvider.java | 14 +++++++++----- 3 files changed, 16 insertions(+), 12 deletions(-) diff --git a/build.gradle b/build.gradle index 702db0a..04b3de5 100644 --- a/build.gradle +++ b/build.gradle @@ -4,18 +4,18 @@ buildscript { mavenCentral() } dependencies { - classpath 'com.android.tools.build:gradle:7.0.1' + classpath 'com.android.tools.build:gradle:7.2.1' } } apply plugin: 'com.android.application' android { - compileSdkVersion 'android-31' - buildToolsVersion '31' + compileSdkVersion 'android-32' + buildToolsVersion '32' defaultConfig { minSdkVersion 26 - targetSdkVersion 28 + targetSdkVersion 32 } buildTypes { @@ -33,6 +33,6 @@ dependencies { allprojects { repositories { google() - jcenter() + mavenCentral() } } diff --git a/src/main/AndroidManifest.xml b/src/main/AndroidManifest.xml index 662bfc3..4e0c87e 100644 --- a/src/main/AndroidManifest.xml +++ b/src/main/AndroidManifest.xml @@ -10,8 +10,8 @@ android:icon="@mipmap/sym_def_app_icon" android:allowBackup="false"> + android:theme="@android:style/Theme.DeviceDefault" + android:exported="true"> diff --git a/src/main/java/org/safsftp/SFTPDocumentsProvider.java b/src/main/java/org/safsftp/SFTPDocumentsProvider.java index ed6f7cb..3c3ef85 100644 --- a/src/main/java/org/safsftp/SFTPDocumentsProvider.java +++ b/src/main/java/org/safsftp/SFTPDocumentsProvider.java @@ -27,6 +27,7 @@ import com.trilead.ssh2.SFTPv3FileAttributes; import com.trilead.ssh2.SFTPv3FileHandle; import java.io.IOException; +import java.util.Locale; import java.util.Vector; public class SFTPDocumentsProvider extends DocumentsProvider { @@ -53,12 +54,15 @@ public class SFTPDocumentsProvider extends DocumentsProvider { }; private static String getMime(String filename) { - int idx=filename.lastIndexOf("."); - if(idx>0){ - String mime=MimeTypeMap.getSingleton() + int idx = filename.lastIndexOf("."); + if(idx > 0){ + String mime = MimeTypeMap.getSingleton() .getMimeTypeFromExtension(filename - .substring(idx+1).toLowerCase()); - if(mime!=null)return mime; + .substring(idx + 1) + .toLowerCase(Locale.ROOT)); + if (mime != null) { + return mime; + } } return "application/octet-stream"; } -- 2.43.0