From b6eaefbc83343a30f22fa3a2017aaf719ae432e5 Mon Sep 17 00:00:00 2001
From: xdavidwu <xdavidwuph@gmail.com>
Date: Sat, 2 Apr 2022 15:02:11 +0800
Subject: [PATCH] UptimeController: unserialize probe only when necessary

---
 app/Http/Controllers/UptimeController.php | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/app/Http/Controllers/UptimeController.php b/app/Http/Controllers/UptimeController.php
index 5487349..283c4bd 100644
--- a/app/Http/Controllers/UptimeController.php
+++ b/app/Http/Controllers/UptimeController.php
@@ -17,8 +17,6 @@ class UptimeController extends Controller
         $instances = ProbeInstance::all();
         $data = [];
         foreach ($instances as $instance) {
-            $probe = unserialize($instance->probe);
-
             $raw_logs = $instance->logs()->where('created_at', '>=', $from)->orderBy('created_at')->get();
             $raw_index = 0;
             $raw_length = count($raw_logs);
@@ -49,7 +47,7 @@ class UptimeController extends Controller
             }
 
             $data[] = [
-                'title' => $instance->title ?? $probe->describe(),
+                'title' => $instance->title ?? unserialize($instance->probe)->describe(),
                 'logs' => $logs,
             ];
         }
-- 
2.43.0