From 237f66e740af4498593bca8116266d9a66c3ad6e Mon Sep 17 00:00:00 2001 From: Michael Rose Date: Tue, 2 Jun 2020 22:33:08 -0400 Subject: [PATCH] Replace custom comment hardcoded HTML with include Also add custom_scripts.html include for custom comment provider JavaScript that loads in the footer. Close #2549 --- CHANGELOG.md | 1 + _includes/comments-providers/custom_scripts.html | 3 +++ _includes/comments-providers/scripts.html | 2 +- _includes/comments.html | 2 +- 4 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 _includes/comments-providers/custom_scripts.html diff --git a/CHANGELOG.md b/CHANGELOG.md index de34536..b20f37a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,7 @@ ### Enhancements +- Replace `
` in `comments.html` include and add `custom_scripts.html` include for loading custom comment provider JavaScript in the footer. [#2549](https://github.com/mmistakes/minimal-mistakes/issues/2549) - Move page date Liquid to include. [#2544](https://github.com/mmistakes/minimal-mistakes/pull/2544) - Strip trailing whitespace in seo_description. [#2542](https://github.com/mmistakes/minimal-mistakes/pull/2542) - Improve sticky sidebar's appearance with short content. [#2514](https://github.com/mmistakes/minimal-mistakes/pull/2514) diff --git a/_includes/comments-providers/custom_scripts.html b/_includes/comments-providers/custom_scripts.html new file mode 100644 index 0000000..6947946 --- /dev/null +++ b/_includes/comments-providers/custom_scripts.html @@ -0,0 +1,3 @@ + + + \ No newline at end of file diff --git a/_includes/comments-providers/scripts.html b/_includes/comments-providers/scripts.html index 4e3f585..c550618 100644 --- a/_includes/comments-providers/scripts.html +++ b/_includes/comments-providers/scripts.html @@ -13,6 +13,6 @@ {% when "utterances" %} {% include /comments-providers/utterances.html %} {% when "custom" %} - {% include /comments-providers/custom.html %} + {% include /comments-providers/custom_scripts.html %} {% endcase %} {% endif %} \ No newline at end of file diff --git a/_includes/comments.html b/_includes/comments.html index 6562f12..dbb90d1 100644 --- a/_includes/comments.html +++ b/_includes/comments.html @@ -154,6 +154,6 @@

{{ comments_label }}

{% when "custom" %} -
+ {% include /comments-providers/custom.html %} {% endcase %} -- 2.45.2