From b0025c78c21ba9c215ab6a4ec063c1a75f6afe29 Mon Sep 17 00:00:00 2001
From: xdavidwu <xdavidwuph@gmail.com>
Date: Sun, 6 Feb 2022 23:01:06 +0800
Subject: [PATCH] sass: dim background on popups, unify impl

---
 _sass/minimal-mistakes/_colors.scss    |  6 ------
 _sass/minimal-mistakes/_noscript.scss  | 30 +++++++++++++-------------
 _sass/minimal-mistakes/_sidebar.scss   | 18 ----------------
 _sass/minimal-mistakes/_utilities.scss | 22 -------------------
 4 files changed, 15 insertions(+), 61 deletions(-)

diff --git a/_sass/minimal-mistakes/_colors.scss b/_sass/minimal-mistakes/_colors.scss
index f160a33..9dc13d8 100644
--- a/_sass/minimal-mistakes/_colors.scss
+++ b/_sass/minimal-mistakes/_colors.scss
@@ -544,12 +544,6 @@ td {
   background: transparent;
 }
 
-.greedy-nav__toggle {
-  &:before {
-    background: $background-color;
-  }
-}
-
 .greedy-nav__toggle:hover {
   .navicon,
   .navicon:before,
diff --git a/_sass/minimal-mistakes/_noscript.scss b/_sass/minimal-mistakes/_noscript.scss
index 272681c..ad11ca8 100644
--- a/_sass/minimal-mistakes/_noscript.scss
+++ b/_sass/minimal-mistakes/_noscript.scss
@@ -21,24 +21,24 @@ input#darkmode, input#lightmode {
   display: none;
 }
 
-input#follow-button + label {
-  &:before {
-    @supports (pointer-events: none) {
-      content: '';
-      position: fixed;
-      top: 0;
-      left: 0;
-      width: 100%;
-      height: 100%;
-      pointer-events: none;
-    }
+.greedy-nav__toggle:before, input#follow-botton:checked + label:before {
+  @supports (pointer-events: none) {
+    content: '';
+    position: fixed;
+    top: 0;
+    left: 0;
+    width: 100%;
+    height: 100%;
+    opacity: 0;
+    transition: $global-transition;
+    pointer-events: none;
+    background: $background-color;
   }
 }
 
-input#follow-button:checked + label {
-  &:before {
-    pointer-events: auto;
-  }
+.greedy-nav__toggle.close:before, input#follow-button:checked + label:before {
+  opacity: 0.9;
+  pointer-events: auto;
 }
 
 label[for="darkmode"], label[for="lightmode"] {
diff --git a/_sass/minimal-mistakes/_sidebar.scss b/_sass/minimal-mistakes/_sidebar.scss
index 1c17799..7811150 100644
--- a/_sass/minimal-mistakes/_sidebar.scss
+++ b/_sass/minimal-mistakes/_sidebar.scss
@@ -196,24 +196,6 @@
     position: relative;
     margin-bottom: 0;
 
-    &:before {
-      @supports (pointer-events: none) {
-        content: '';
-        position: fixed;
-        top: 0;
-        left: 0;
-        width: 100%;
-        height: 100%;
-        pointer-events: none;
-      }
-    }
-
-    &.open {
-      &:before {
-        pointer-events: auto;
-      }
-    }
-
     @include breakpoint($large) {
       display: none;
     }
diff --git a/_sass/minimal-mistakes/_utilities.scss b/_sass/minimal-mistakes/_utilities.scss
index 4825c0e..211af4b 100644
--- a/_sass/minimal-mistakes/_utilities.scss
+++ b/_sass/minimal-mistakes/_utilities.scss
@@ -248,28 +248,6 @@ body:hover .visually-hidden button {
   }
 }
 
-.greedy-nav__toggle {
-  &:before {
-    content: '';
-    position: fixed;
-    top: 0;
-    left: 0;
-    width: 100%;
-    height: 100%;
-    opacity: 0;
-    transition: $global-transition;
-    pointer-events: none;
-  }
-
-  &.close {
-    &:before {
-      opacity: 0.9;
-      transition: $global-transition;
-      pointer-events: auto;
-    }
-  }
-}
-
 /*
    Sticky, fixed to top content
    ========================================================================== */
-- 
2.43.0