~xdavidwu/xdavidwu.link

23014f604527f86dbd0d68b31d7b80e05c31eb9d — Michael Rose 6 years ago 11e5704
Improve accessibility of navigation menu button

Add `type` and label text.

Fixes #1099
2 files changed, 5 insertions(+), 1 deletions(-)

M CHANGELOG.md
M _includes/masthead.html
M CHANGELOG.md => CHANGELOG.md +1 -0
@@ 7,6 7,7 @@
- Add note about Staticman GitHub compatibility. [#1273](https://github.com/mmistakes/minimal-mistakes/issues/1273)
- Add missing Brazilian Portuguese translations to `ui-text.yml`. [#1278](https://github.com/mmistakes/minimal-mistakes/pull/1278)
- Update font stack documentation. [#1292](https://github.com/mmistakes/minimal-mistakes/pull/1292)
- Improve accessibility of navigation menu button. [#1099](https://github.com/mmistakes/minimal-mistakes/issues/1099)

### Bug Fixes


M _includes/masthead.html => _includes/masthead.html +4 -1
@@ 13,7 13,10 @@
            <li class="masthead__menu-item"><a href="{{ domain }}{{ link.url }}">{{ link.title }}</a></li>
          {% endfor %}
        </ul>
        <button><div class="navicon"></div></button>
        <button type="button">
          <span class="visually-hidden">{{ site.data.ui-text[site.locale].menu_label | default: "Toggle Menu" }}</span>
          <div class="navicon"></div>
        </button>
        <ul class="hidden-links hidden"></ul>
      </nav>
    </div>